This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: expose Buffer on the dist version #523
Comments
@interfect fair point. Would you like to submit a PR that exposes Buffer under |
daviddias
changed the title
API doesn't make sense in the browser
feat: expose Buffer on the dist version
Oct 17, 2016
since it is being handled here: #525 |
This was referenced Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
According to the API spec, you're supposed to pass a node
Buffer
, a nodeReadable
stream, or an object containing one of those to theipfs.files.add
method. However, this project advertises the ability to use the implementation by including a<script>
tag:If you do include that tag, you get a global
Ipfs
object, and you can indeed start up a node and go online. But since in the global namespace there is noBuffer
orReadable
stream implementation, what are you supposed to pass toipfs.files.add
? It would seem to be requiring types that can't be created outside it's fancy webpack module that hides all the node globals.The text was updated successfully, but these errors were encountered: