Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

No routes for HTTP Gateway #693

Closed
harshjv opened this issue Jan 1, 2017 · 6 comments
Closed

No routes for HTTP Gateway #693

harshjv opened this issue Jan 1, 2017 · 6 comments

Comments

@harshjv
Copy link
Contributor

harshjv commented Jan 1, 2017

Currently, HTTP gateway has no routes so even if daemon is listening to 9090 isn't useful.

Gateway (readonly) is listening on: http://127.0.0.1:9090

Is there any progress on this part? I would like to help in implementing gateway functionality for js-ipfs

@daviddias
Copy link
Member

Hi @harshjv, we haven't made any development with regards to the IPFS gateway in js-ipfs, however, a lot of the groundwork is done for the HTTP API, which shares a lot of the same endpoints with the gateway.

Having the HTTP Gateway in the JS implementation is not a core priority, so it might take a while until we take a stab at it, however, if you are available, that would be awesome and I'm happy to provide all the feedback you might need :)

@daviddias daviddias mentioned this issue Jan 2, 2017
@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Jan 2, 2017
@harshjv
Copy link
Contributor Author

harshjv commented Jan 2, 2017

Hey @diasdavid I can help in this issue as currently, I am using js-ipfs for Buffet (Cross platform IPFS application with built-in managed IPFS-node) and in that, I've already implemented file cat/get gateway functionality with directory node browsing and mime-type support.

It can also add files with wrap-with-directory option (using fake parent directory)

It would be great if you can review these two files (and related other project files), and let me know if everything looks good to you so that I can port it to js-ipfs.

https://github.com/harshjv/buffet/blob/master/app/gateway/routes.js
https://github.com/harshjv/buffet/blob/master/app/utils/ipfs.js

Cheers 🍻

@daviddias
Copy link
Member

Overall LGTM, but it will get more review as it will be easier once there is a PR against js-ipfs :)

@harshjv
Copy link
Contributor Author

harshjv commented Jan 3, 2017

Cool then. I'll send a PR soon :)

@harshjv
Copy link
Contributor Author

harshjv commented Jan 3, 2017

@diasdavid Hey, I've sent a PR #698 for this. :)

@daviddias
Copy link
Member

Let's continue the discussion on your PR #698, @harshjv :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants