feat: convert to typescript #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts this module to typescript
SgtPooki
approved these changes
Sep 30, 2022
Comment on lines
+73
to
+75
| apiAddr: nodes[id].apiAddr?.toString(), | ||
| gatewayAddr: nodes[id].gatewayAddr?.toString(), | ||
| grpcAddr: nodes[id].grpcAddr?.toString(), |
There was a problem hiding this comment.
we're changing the results from being '' (empty string) when undefined, to being undefined. Is this okay?
Comment on lines
+125
to
+127
| apiAddr: nodes[id].apiAddr?.toString(), | ||
| gatewayAddr: nodes[id].gatewayAddr?.toString(), | ||
| grpcAddr: nodes[id].grpcAddr?.toString() |
There was a problem hiding this comment.
we're changing the results from being '' (empty string) when undefined, to being undefined. Is this okay?
There was a problem hiding this comment.
Yes, I think it's a bit better like as these fields will be stripped out on JSON encode now as they're undefined instead of being an empty string which is not a valid string representation of a multiaddr.
achingbrain
commented
Oct 1, 2022
SgtPooki
approved these changes
Oct 3, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## [12.1.0](v12.0.3...v12.1.0) (2022-10-04) ### Features * convert to typescript ([#777](#777)) ([ee3a35a](ee3a35a))
|
🎉 This PR is included in version 12.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts this module to typescript