Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return gateway href in .info response #850

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Nov 14, 2024

In order to not re-add the multiaddr dependency, we're just returning the gateway response as a string. Users will need to parse the string with @multiformats/multiaddr or other means.

We are reading the gateway href from $REPO_PATH/gateway file now.

Fixes #831

Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@SgtPooki SgtPooki requested a review from achingbrain November 14, 2024 21:17
@SgtPooki SgtPooki self-assigned this Nov 14, 2024
@SgtPooki SgtPooki changed the title fix: return gateway maddr in .info response fix: return gateway href in .info response Nov 14, 2024
@SgtPooki SgtPooki merged commit c9dafd0 into master Nov 21, 2024
19 checks passed
@SgtPooki SgtPooki deleted the 831-feat-add-back-controllerapigatewayhost-and-controllerapigatewayport-or-similar branch November 21, 2024 16:50
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
## [15.0.2](v15.0.1...v15.0.2) (2024-11-21)

### Bug Fixes

* return gateway href in .info response ([#850](#850)) ([c9dafd0](c9dafd0))
Copy link

🎉 This PR is included in version 15.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add back controller.api.gatewayHost and controller.api.gatewayPort or similar
1 participant