fix: verify public key exists in validator #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
approved these changes
Apr 3, 2019
|
I will merge this, as the CI failing is windows constantly with no response in 10 minutes and in the |
|
This landed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running my local js-ipfs daemon it crashed when running the IPNS validator. Currently if the validator runs and cannot get an embedded public key it will attempt to use the public key of the peer. However, the validator doesn't have access to the peer public key, as it creates the peerId from bytes.
I'm not very familiar with the IPNS code base so there may be a better way to resolve this. This simply ensures that
extractPublicKeyactually returns a key.