fix: align implicit default ttl with specs (1h→5m) #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same rationale as ipfs/helia#749
lidel
force-pushed
the
ipns-ttl-5m-default
branch
from
3dbd4f4 to
3c5d8ae
Compare
|
@achingbrain mind taking a look and release if no concerns? |
2color
approved these changes
Mar 18, 2025
achingbrain
approved these changes
Mar 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
## [10.0.2](v10.0.1...v10.0.2) (2025-03-18) ### Bug Fixes * align implicit default ttl with specs (1h→5m) ([#336](#336)) ([5677cf0](5677cf0)) ### Trivial Changes * Create FUNDING.json for OP RPF ([#335](#335)) ([de2e786](de2e786)) ### Dependencies * **dev:** bump aegir from 44.1.4 to 45.0.8 ([#332](#332)) ([c2d611a](c2d611a))
|
🎉 This PR is included in version 10.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is changing implicit default TTL of IPNS Record produced by this library from 1h to 5m.
Same rationale as ipfs/kubo#10718 and ipfs/helia#749. This library has its own default TTL, which is separate from one we already updated ipfs/helia#749. Making this change so we have the same default everywhere.
Historical notes
1hdefault produced by this library started causing stale cache issues that end users often report as "ipns is slow (to update/propagate)".