feat: add records validator #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
force-pushed
the
feat/add-records-validator
branch
from
fa7e587
to
2314664
Compare
fsdiogo
suggested changes
Sep 6, 2018
README.md
Outdated
|
|
||
| The `validate` function aims to verify if an IPNS record is valid. First the record is unmarshalled, then the public key is obtained and finally the record is validated (signature and validity are verified). | ||
|
|
||
| The `select` function is responsible for deciding which ipns record is the best (newer) between two records. Both records are unmarshalled and their sequece numbers are compared. If the first record provided is the newer, the operation result will be `0`, otherwise the operation result will be `1`. |
There was a problem hiding this comment.
Typo:
"Both records are unmarshalled and their sequence numbers are compared."
test/index.spec.js
Outdated
| }) | ||
| }) | ||
|
|
||
| it('should use validator.select to select the newer record returning 0 if it is the first parameter', (done) => { |
There was a problem hiding this comment.
'should use validator.select to select the first record because it is newer'?
test/index.spec.js
Outdated
| }) | ||
| }) | ||
|
|
||
| it('should use validator.select to select the newer record returning 1 if it is the second parameter', (done) => { |
fsdiogo
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipnsshould offer a validator capable of validate records, as well select which one is the best record between two of them (using the sequence number).This is particularly useful for validating libp2p records transparently, providing this validator.
Note:
go-ipnsalso provides this feature here