feat: prevent side effect on create
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kind ping @vasco-santos |
|
Hello @eordano ! Sorry, for the late answer. When creating a PR, please ask for a review directly as I will receive an email and it will be faster 🙂 |
vasco-santos
requested changes
Sep 20, 2018
src/index.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Same as create(), but prevent generating a Date(). |
There was a problem hiding this comment.
Same as create(), but instead of generating a new Date, it receives the intended expiration time
src/index.js
Outdated
| * @param {Object} privateKey private key for signing the record. | ||
| * @param {string} value value to be stored in the record. | ||
| * @param {number} seq number representing the current version of the record. | ||
| * @param {string} expiration lifetime of the record (in nanoseconds). |
There was a problem hiding this comment.
Update the description of the expiration to something expiration time of the record (in nanoseconds)
|
Updated based on comments (thanks @vasco-santos!) |
This allows two `createWithExpiration` to have the same return value without mocking the global `require('nano-date')`
|
Kind ping @vasco-santos |
|
@eordano just released |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows two
createWithExpirationto have the same return value without mocking the globalrequire('nano-date')