Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip (but leave) tests that were being skipped in interface-ipfs-core #52

Closed
SgtPooki opened this issue Oct 14, 2022 · 2 comments
Closed
Assignees

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Oct 14, 2022

some tests are skipped in https://github.com/ipfs/js-kubo-rpc-client/blob/c899abbc32d0f46b55fdda896c6f32240b49d1c6/test/interface-tests.spec.js

Skip them using

const notImplemented = () => true
instead

Some of these tests that are skipped looked like they should have been removed from the skip list a while ago, and I think leaving that determination up to Kubo team is the right call.

@SgtPooki SgtPooki changed the title Remove tests that are skipped in https://github.com/ipfs/js-kubo-rpc-client/blob/c899abbc32d0f46b55fdda896c6f32240b49d1c6/test/interface-tests.spec.js Remove tests that are skipped Oct 14, 2022
@SgtPooki SgtPooki changed the title Remove tests that are skipped Skip (but leave) skipped tests. Oct 17, 2022
@SgtPooki SgtPooki changed the title Skip (but leave) skipped tests. Skip (but leave) tests that were being skipped in interface-ipfs-core Oct 17, 2022
@SgtPooki SgtPooki self-assigned this Oct 17, 2022
@BigLep
Copy link
Contributor

BigLep commented Oct 17, 2022

Some of these tests that are skipped looked like they should have been removed from the skip list a while ago, and I think leaving that determination up to Kubo team is the right call.

@SgtPooki : when you say removed from the skip list, do you mean that they should be enabled or be deleted?

@SgtPooki
Copy link
Member Author

superseded by #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants