Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support storing UnixFS Owner #10577

Closed
3 tasks done
yuzhou-nj opened this issue Nov 11, 2024 · 1 comment
Closed
3 tasks done

Support storing UnixFS Owner #10577

yuzhou-nj opened this issue Nov 11, 2024 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@yuzhou-nj
Copy link

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

The ipfs add command supports --preserve-mode and --preserve-mtime. Is it possible to also support --preserve-owner? This would allow changes made by chown to be preserved when adding files with ipfs add.

for example:

# ipfs add --preserve-mode --preserve-mtime test.json
added QmbwaAtVk282BkCwK18FDXniC26sTmZqSJvwRAVPAm3fV8 test.json

# chown oracle test.json
# ipfs add --preserve-mode --preserve-mtime test.json
added QmbwaAtVk282BkCwK18FDXniC26sTmZqSJvwRAVPAm3fV8 test.json  <--not changed

thank you!

@yuzhou-nj yuzhou-nj added the kind/enhancement A net-new feature or improvement to an existing feature label Nov 11, 2024
@lidel lidel changed the title Support storing UnixFS 1.5 Owner Support storing UnixFS Owner Nov 12, 2024
@lidel
Copy link
Member

lidel commented Nov 12, 2024

No, owner is not part of Unixfs 1.5 (only mode and mtime), so it is not possible atm.

If you want to preserve owner information, wrap your data in a TAR, and store that.

Adding support for it would require IPIP spec proposal in https://github.com/ipfs/specs/ and requires ipfs/specs#331 to land first.

I'm closing this, because there is no spec for Kubo to implement, but if you would like to kick-off discussion about adding owner support to UnixFS specs, feel free to open issue in https://github.com/ipfs/specs/issues, or even propose an IPIP yourself.

If there is a spec, open issuer in Kubo to implement it.

@lidel lidel closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants