-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accelerated client includes outdated(?) addrs #10737
Comments
The normal DHT Client The accelerated DHT Client So the logic is different between the normal and accelerated DHT clients, and the accelerated DHT client is expected to find a superset of addresses, some of them may be stale? Is this behaviour new? There was a recent code change in the Accelerated DHT Client that may be related. |
This does not seem to be new, probing the same peer with The Could it be, the problem here is not a bug in Kubo/kad-dht, but one of the peers that accelerated client hits? If a third-party peer that does not use upstream code does not forget addresses after 15 minutes, but keeps them longer, would it explain this behavior? |
When the accelerated DHT client is enabled, the DHT crawler will enumerate all the peers and dump their routing tables. It will write every address received about any other peer in the host peerstore, without dialing the addresses first. Hence if multiple nodes run the accelerated DHT client, they will keep infecting each other with outdated addresses and these addresses will never disappear from the DHT routing tables. |
Do you expect this change might alleviate some the pain of running the accelerated DHT Crawler itself? I've found that to be the largest point of pain trying to host IPFS content on non-dedicated internet. |
Checklist
Installation method
docker image
Version
Config
`ipfs config --json Routing.AcceleratedDHTClient true`
Description
Without accelerated client, we get normal address list:
With
ipfs config --json Routing.AcceleratedDHTClient true
identify returns a lot more addrs:The text was updated successfully, but these errors were encountered: