Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs init is not reporting failures #1130

Closed
Luzifer opened this issue Apr 23, 2015 · 2 comments
Closed

ipfs init is not reporting failures #1130

Luzifer opened this issue Apr 23, 2015 · 2 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) topic/commands Topic commands topic/daemon + init

Comments

@Luzifer
Copy link
Member

Luzifer commented Apr 23, 2015

Given the $IPFS_PATH is not writable for ipfs init the command does show the output we're used to as if it worked fine. Instead it should show an fatal error because ipfs init is in fact not able to write into that directory and it is empty afterwards which causes strange errors:

# echo $IPFS_PATH
/data/ipfs

# ls -lhR /data
/data:
total 4.0K
drwxr-xr-x 2 root root 4.0K Apr 23 20:58 ipfs

/data/ipfs:
total 0

# ipfs version
ipfs version 0.3.2

# ipfs init
initializing ipfs node at /data/ipfs
generating 2048-bit RSA keypair...done
peer identity: QmfJZTJVaDcfDfxs6LpwEqiAtqxGa2rkCpTTqMPgoZwdMm

# ipfs daemon
Initializing daemon...
Error: no ipfs repo found. please run: ipfs init
@whyrusleeping whyrusleeping added kind/bug A bug in existing code (including security flaws) topic/commands Topic commands topic/daemon + init labels Apr 24, 2015
@whyrusleeping
Copy link
Member

Good catch, should be a moderately easy fix in cmd/ipfs/init.go or maybe somewhere in repo/fsrepo.

@jbenet
Copy link
Member

jbenet commented Apr 27, 2015

woahhh interesting. we should add a test case for this to sharness tests.

@whyrusleeping whyrusleeping mentioned this issue May 11, 2015
30 tasks
@jbenet jbenet mentioned this issue May 19, 2015
52 tasks
@RichardLitt RichardLitt added the exp/novice Someone with a little familiarity can pick up label Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) topic/commands Topic commands topic/daemon + init
Projects
None yet
Development

No branches or pull requests

5 participants