Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dialing known _local_ addresses when not in that network #1246

Closed
2 tasks
jbenet opened this issue May 18, 2015 · 2 comments
Closed
2 tasks

Avoid dialing known _local_ addresses when not in that network #1246

jbenet opened this issue May 18, 2015 · 2 comments
Labels
help wanted Seeking public contribution on this issue topic/libp2p Topic libp2p

Comments

@jbenet
Copy link
Member

jbenet commented May 18, 2015

See #1226

Change p2p/net to avoid dialing known local area network addresses when not in that local network.

For example, it does not make sense to dial a 192.168.0.0/16 address when not within that subnet. This alone will cut out most -- if not all -- of the sysadmin netscan warnings. Most VPSes are in different networks.

We need to:

  • identify a list of all subnets that we should do this with.
  • implement the changes
@whyrusleeping
Copy link
Member

my thoughts for a simple, "quick and easy" solution are to provide a config setting to allow users to specify which ranges to avoid dialing.

@whyrusleeping whyrusleeping mentioned this issue May 26, 2015
49 tasks
@whyrusleeping whyrusleeping mentioned this issue Jun 2, 2015
58 tasks
@whyrusleeping whyrusleeping mentioned this issue Jun 9, 2015
50 tasks
@jbenet jbenet mentioned this issue Jun 16, 2015
55 tasks
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Aug 23, 2016
@Stebalien
Copy link
Member

Moving to libp2p: libp2p/go-libp2p#436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue topic/libp2p Topic libp2p
Projects
None yet
Development

No branches or pull requests

3 participants