Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

each CLI command makes two api requests #1990

Closed
whyrusleeping opened this issue Nov 22, 2015 · 3 comments · Fixed by #2037
Closed

each CLI command makes two api requests #1990

whyrusleeping opened this issue Nov 22, 2015 · 3 comments · Fixed by #2037
Assignees

Comments

@whyrusleeping
Copy link
Member

every cli command that gets run makes two API requests, one to /version to check compatibility, and another for the actual command. It seems to me like the version check could be embedded in headers and done alongside the command itself.

@rht
Copy link
Contributor

rht commented Nov 22, 2015

iirc there was a rtt bug where it is twice longer than it should be, could this be the cause?

@rht
Copy link
Contributor

rht commented Nov 22, 2015

#1303

@whyrusleeping
Copy link
Member Author

no, this is just because the commands client makes a version request to check versions, and then make the actual request if the version check passes. it happens inside this call here: https://github.com/ipfs/go-ipfs/blob/master/cmd/ipfs/main.go#L406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants