Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile should check installed version of go #2397

Closed
whyrusleeping opened this issue Feb 23, 2016 · 6 comments
Closed

makefile should check installed version of go #2397

whyrusleeping opened this issue Feb 23, 2016 · 6 comments

Comments

@whyrusleeping
Copy link
Member

@chriscool could you put this together? You already did it nicely for gx versions, and reusing that code would be great.

@chriscool
Copy link
Contributor

Ok, I will take a look soon.

@chriscool
Copy link
Contributor

By the way should we just test that go version is >= 1.5? Or are there other things to test, like go version < 1.6?

@ghost
Copy link

ghost commented Feb 23, 2016

go version is >= 1.5

= 1.5.2

go version < 1.6

not sure anyone has tested with 1.6 yet

@Stebalien
Copy link
Member

I'm running IPFS with go 1.6 and haven't noticed any issues.

@whyrusleeping
Copy link
Member Author

yeah, we fixed the couple issues that 1.6 brought up, so it should work. but i won't recommend it as an official supported version until we get CI running it.

For now, just saying greater than 1.5.2 should be good

@chriscool
Copy link
Contributor

Ok, thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants