-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile should check installed version of go #2397
Comments
Ok, I will take a look soon. |
By the way should we just test that go version is >= 1.5? Or are there other things to test, like go version < 1.6? |
not sure anyone has tested with 1.6 yet |
I'm running IPFS with go 1.6 and haven't noticed any issues. |
yeah, we fixed the couple issues that 1.6 brought up, so it should work. but i won't recommend it as an official supported version until we get CI running it. For now, just saying greater than 1.5.2 should be good |
Ok, thanks all! |
@chriscool could you put this together? You already did it nicely for gx versions, and reusing that code would be great.
The text was updated successfully, but these errors were encountered: