Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aborting command on daemon when client process terminated #242

Closed
btc opened this issue Oct 30, 2014 · 2 comments
Closed

Aborting command on daemon when client process terminated #242

btc opened this issue Oct 30, 2014 · 2 comments
Labels
kind/support A question or request for support

Comments

@btc
Copy link
Contributor

btc commented Oct 30, 2014

  1. Run daemon
  2. execute ipfs add on client
  3. Terminate the client

Daemon continues execution.

Preferred behavior is for the daemon to abort the action. Any thoughts on feasibility?

@btc btc added the kind/support A question or request for support label Oct 30, 2014
@whyrusleeping
Copy link
Member

This is really hard to do right... the client would have to be continually reading on the socket waiting for some sort of 'cancel' message. which changes the architecture a bit, but if we figure that part out, cancelling the command should be as simple as canceling its context

@jbenet
Copy link
Member

jbenet commented Jan 15, 2015

There is already a context in place, it just needs to be wired up to all the commands that may wait.

@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support A question or request for support
Projects
None yet
Development

No branches or pull requests

3 participants