Config set fails if there is entry in config that is integer bigger than 1e6

[Kubuxu]

I have BloomSize set to 1048576, if I then try to do any config call, example

ipfs config --json API.HTTPHeaders.Access-Control-Allow-Origin '["*"]'

I get:

Error: failed to set config value: Failure to decode config: json: cannot unmarshal number 1.048576e+06 into Go value of type int (maybe use --json?)

The integer is being transformed into floating point at some point.

[whyrusleeping]

Thats.... annoying

[Kubuxu]

I will hit it if I set the bloom filter size on storage hosts to 128MiB.

[Kubuxu]

The reason for it is our trickery with map[string]interface{} for replacing single variables and so on.

@whyrusleeping @lgierth any idea how to handle it?

[torresashjian]

After doing some testing:
1.- BloomSize value <= 9223372036854775000
Result: [All good]

2.- 9223372036854775000 > BloomSize value < 9223372036854775295
Result: [BloomSize Value rounded and changed to 9223372036854775000]

3.- When BloomSize value > 9223372036854775295
Result: [Error: failed to set config value: Failure to decode config: json: cannot unmarshal number 9223372036854776000 into Go struct field Datastore.BloomFilterSize of type int (maybe use --json?)]

If we use in repo/fsrepo/serialize/serialize.go:

d := json.NewDecoder(f)
d.UseNumber()

Then the rounding happens between 9223372036854775000 and 9223372036854776000, little gain, but the error message is more in sync with the values since it fails at > 9223372036854776000.

Other options could be using RawMessage to delay the resolution of the values until is is used or set, this way each value is independent from each other and only the desired part gets decoded, with some other tradeoffs of course....

The number allowed seems large enough for a Bloom Filter, so not sure a fix is needed here.

[Kubuxu]

Solution for the bloom filter would be migration for it to be string instead with unit suffix.

[Kubuxu]

Solution for it also is using custom json decoder and https://golang.org/pkg/encoding/json/#Decoder.UseNumber