Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs multiaddrs should include ".../ipfs/..." #368

Closed
jbenet opened this issue Nov 20, 2014 · 3 comments
Closed

ipfs multiaddrs should include ".../ipfs/..." #368

jbenet opened this issue Nov 20, 2014 · 3 comments
Assignees
@jbenet
Milestone
α

Comments

@jbenet
Copy link
Member

jbenet commented Nov 20, 2014 

% ipfs bootstrap
/ip4/104.131.131.82/tcp/4001/QmaCpDMGvV2BGHeYERUEnRQAwe3N8SzbUtfsmvsqQLuvuJ
/ip4/192.168.1.121/tcp/4001/QmUF5Zjcj9XMBbtuS3JNhHzTsaBiqRDLwydm8dVyDm8Lrq

should be

% ipfs bootstrap
/ip4/104.131.131.82/tcp/4001/ipfs/QmaCpDMGvV2BGHeYERUEnRQAwe3N8SzbUtfsmvsqQLuvuJ
/ip4/192.168.1.121/tcp/4001/ipfs/QmUF5Zjcj9XMBbtuS3JNhHzTsaBiqRDLwydm8dVyDm8Lrq
@jbenet
Copy link
Member Author

jbenet commented Jan 15, 2015

This is a userland thing, so i think we should try to make it before the alpha. We can kick it out if we need to.

@jbenet jbenet added this to the α milestone Jan 15, 2015
@jbenet jbenet self-assigned this Jan 15, 2015
@jbenet
Copy link
Member Author

jbenet commented Jan 20, 2015

  • multiaddr now supports ipfs and http: multiformats/go-multiaddr@f529ec7
  • bring changes into ipfs
  • change config to use just only string addresses for bootstrap peers (instead of object)
  • change code that handles bootstrap peers all over the place
  • change code that special-cases the printing out of ipfs addresses to use new multiaddr

@jbenet
Copy link
Member Author

jbenet commented Jan 21, 2015

fixing in #608

@jbenet jbenet closed this as completed Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbenet jbenet

Labels
None yet
Projects
None yet
Milestone
α
Development

No branches or pull requests
1 participant
@jbenet