Nitpick: Maximum block size is poorly defined

[icefoxen]

Version information:

Git master as of commit 8b90b70

Type: Bug

Severity: medium/maybe low

Description: Maximum block size is platform dependent

As defined in the BlockStat struct, the size of a block is taken by the len() function, which returns an int. The size of this differs on different platforms; ie int32 on 32-bit machines, int64 on 64-bit machines. So, it's possible for a 64-bit machine to create a block that a 32-bit machine can't process.

[magik6k]

For most purposes maximum block size will be 4MB - (size of bitswap header), this is due to message size limit in libp2p, which is there mostly for security reasons.

https://github.com/libp2p/go-libp2p-net/blob/master/interface.go#L20

But yeah, this info should be easier to find.

[Stebalien]

Note: In theory, you can define arbitrarily large blocks. You just won't be able to bitswap them (and IPFS may fall over at some point).