(regression?) ipfs add -r
does not follow symlink directories on Windows
#4750
Labels
ipfs add -r
does not follow symlink directories on Windows
#4750
Version information:
go-ipfs version: 0.4.13-
Repo version: 6
System version: amd64/windows
Golang version: go1.9.2
Type:
Bug
Description:
In go-ipfs version 0.4.10 the command
ipfs add -r directoryName
wheredirectoryName
is a name of a directory symlink (created bymklink /D
) worked fine on Windows (i.e. go-ipfs followed a symlink and added the linked directory's contents recursively).Having upgraded to go-ipfs version 0.4.13 I have immediately noticed that the same command does not work any longer and outputs the following (where my
directoryName
isshared_singular
):Also go-ipfs 0.4.13 seems to exit prematurely in such case, as indicated by the following:
the character
?
is still visible after the slash in the progress bar;the newline character is not inserted after the progress bar (for example, if go-ipfs is called in a batch file and immediately followed by the
pause
command, then the output ofpause
immediately follows the last-=]
characters instead of a new line).This bug can be reilably reproduced by running
mkdir testDir
andmklink /D testLink testDir
and finallyipfs add -r testLink
all in the same (previously clean) directory on Windows. (Though you may want to put some files intestDir
after its creation to make it more obvious that these files are ignored by go-ipfs.)The text was updated successfully, but these errors were encountered: