Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFS root shouldn't need to put the node in the DAG. #5171

Closed
Stebalien opened this issue Jun 29, 2018 · 2 comments
Closed

MFS root shouldn't need to put the node in the DAG. #5171

Stebalien opened this issue Jun 29, 2018 · 2 comments
Assignees
@schomatis
Labels
P4 Very low priority topic/MFS Topic MFS topic/technical debt Topic technical debt

Comments

@Stebalien
Copy link
Member

If you look at the closeChild implementation in the mfs Root, you'll see that it adds the root object's node to the DAG:

https://github.com/ipfs/go-ipfs/blob/336520d4ef0d06ac28b6e6c189c3d4c099b1ba38/mfs/system.go#L162-L172

However, the child should already have done this.
@Stebalien Stebalien added topic/technical debt Topic technical debt P4 Very low priority labels Jun 29, 2018
@schomatis schomatis self-assigned this Jul 1, 2018
@schomatis schomatis added the topic/MFS Topic MFS label Jul 1, 2018
@schomatis
Copy link
Contributor

For more context about the underlying process see #5066 (comment).

@schomatis schomatis mentioned this issue Dec 13, 2018
Closed
@schomatis
Copy link
Contributor

Closing in favor of ipfs/go-mfs#34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schomatis schomatis

Labels
P4 Very low priority topic/MFS Topic MFS topic/technical debt Topic technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @schomatis