Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecosystem: please add and use consistently tagged releases #5410

Closed
dignifiedquire opened this issue Aug 30, 2018 · 1 comment
Closed

Ecosystem: please add and use consistently tagged releases #5410

dignifiedquire opened this issue Aug 30, 2018 · 1 comment

Comments

@dignifiedquire
Copy link
Member

Currently many modules have some (gx-)releases git tagged, and some don't. Often it is the case that newer ones are not tagged, with older ones being tagged.

With the introduction of go modules in go 1.11 (also known as vgo) this becomes a real issue. As far as I can tell, the go module resolver uses git tags, if present and formatted accordingly, to determine the available versions. This creates an issue when trying to install some of the packages in the libp2p/ipfs ecosystem, as "latest" now means "last tagged release", which is not equal to actual "latest release". This is fixable by hand most of the time, fetching specific commits, but it would be much nicer to just make it work out of the box.

From my understanding there are two things to do to resolve this

  1. Manually/using a script, tag all releases in the various repos
  2. Add auto tagging for gx releases, so this is consistent in the future: Make ReleaseCmd add a git tag whyrusleeping/gx#157
@Kubuxu
Copy link
Member

Kubuxu commented Apr 4, 2019

As we introduced go modules #6038 we will tag consistently.

@Kubuxu Kubuxu closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants