Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking goroutines on datastore queries #5852

Closed
Stebalien opened this issue Dec 18, 2018 · 2 comments
Closed

Leaking goroutines on datastore queries #5852

Stebalien opened this issue Dec 18, 2018 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws) topic/gateway Topic gateway

Comments

@Stebalien
Copy link
Member

We're leaking goroutines on datastore queries when:

  1. Using flatfs.
  2. Closing them early.

Fix: ipfs/go-ds-flatfs#51
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Dec 18, 2018
@Stebalien
Copy link
Member Author

cc @kyledrake

@Stebalien Stebalien added the topic/gateway Topic gateway label Dec 18, 2018
@Stebalien Stebalien mentioned this issue Dec 19, 2018
Merged
@magik6k
Copy link
Member

magik6k commented Dec 20, 2018

Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) topic/gateway Topic gateway
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @magik6k