remove "testing" imports in files that do not end in _test.go

[btc]

These imports cause testing flags to be parsed in binaries that include go-ipfs/core.

[jbenet]

% egrep -r '"testing"' . | egrep -v "_test.go"
./blockservice/mock.go: "testing"
./blockservice/worker/bench/main.go:    "testing"
./Godeps/_workspace/src/bazil.org/fuse/fs/fstestutil/mounted.go:    "testing"
./Godeps/_workspace/src/github.com/jbenet/go-peerstream/transport/test/ttest.go:    "testing"
./merkledag/mock.go:    "testing"
./p2p/test/util/key.go: "testing"
./p2p/test/util/util.go:    "testing"
./test/bench/bench_cli_ipfs_add/main.go:    "testing"
./thirdparty/assert/assert.go:import "testing"
./util/testutil/gen.go: "testing"
./util/testutil/identity.go:    "testing"

not sure what we want to do about all the test utils. can _test.go files export symbols to be included in code from other _test.go files in other packages? If so, we can enforce all testutil stuff is renamed _test.go

[wking]

On Fri, Jan 23, 2015 at 07:20:04PM -0800, Juan Batiz-Benet wrote:

not sure what we want to do about all the test utils. can _test.go
files export symbols to be included in code from other _test.go
files in other packages?

I don't think they can. I'd like to move all shared test utilities
into util/testutil/… though, and we can use non-_test packages there
without polluting the core API. Related to #1158.

I'm happy to start working on this, since cyclic imports bit me while
writing #1136.

[daviddias]

$ egrep -r '"testing"' . | egrep -v "_test.go"
egrep: ./Godeps/_workspace/src/github.com/jbenet/go-multihash/test/sharness/bin: No such file or directory
./Godeps/_workspace/src/bazil.org/fuse/fs/fstestutil/mounted.go:        "testing"
./Godeps/_workspace/src/github.com/jbenet/go-datastore/test/assert.go:import "testing"
./Godeps/_workspace/src/github.com/jbenet/go-datastore/test/test_util.go:    "testing"
./Godeps/_workspace/src/github.com/jbenet/go-peerstream/muxtest/muxt.go:     "testing"
./Godeps/_workspace/src/github.com/jbenet/go-stream-muxer/test/ttest.go:     "testing"
./p2p/test/util/key.go: "testing"
./p2p/test/util/util.go:        "testing"
./test/bench/bench_cli_ipfs_add/main.go:        "testing"
./test/bench/offline_add/main.go:       "testing"
./test/sharness/t0250-files-api.sh:             echo "testing" | ipfs files write -f=false -e /cats/walrus
./thirdparty/assert/assert.go:import "testing"
./util/testutil/gen.go: "testing"
./util/testutil/identity.go:    "testing"

Seems all good now, closing :)