16 data races

[kpp]

Version information:

go-ipfs version: 0.5.0-dev-d61269f41
Repo version: 7
System version: amd64/linux
Golang version: go1.12.8

Howto build

go build -race  "-asmflags=all='-trimpath='" "-gcflags=all='-trimpath='" -ldflags="-X "github.com/ipfs/go-ipfs".CurrentCommit=d61269f41" -o "cmd/ipfs/ipfs" "github.com/ipfs/go-ipfs/cmd/ipfs"

Run

./cmd/ipfs/ipfs daemon 2> data_races.txt

Description:

I got 16 data races from ipfs daemon while running ipfs cat ...

data_races.txt

[Stebalien]

Most of these are libp2p/go-libp2p#257. The MDNS library has races.

However, the address race is new (and luckily not in 0.4.22): libp2p/go-libp2p-swarm#136.

[kpp]

The MDNS library has races.

@Stebalien here is the fix whyrusleeping/mdns#5

[Stebalien]

@kpp. I've merged the changes into go-ipfs master. Mind testing?

[kpp]

Which branch?

[Stebalien]

Master.

[Stebalien]

Wait, nevermind. I haven't merged it yet 🙄.

[Stebalien]

Ok, now it has been merged.

[kpp]

Fixed.

[Stebalien]

Awesome! Thanks making this happen!

[kpp]

The question is: did I fix mdns data races without affecting the logic? You will have make integration tests ;)

[Stebalien]

Unfortunately, reliable mdns integration tests require some form of fake network. That will have to wait for some of our test network work. :(.