Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling HAMT sharing for directories leads to nil pointer dereference #6894

Closed
RubenKelevra opened this issue Feb 12, 2020 · 1 comment
Closed
Labels
kind/bug A bug in existing code (including security flaws) status/duplicate This issue or pull request already exists

Comments

@RubenKelevra
Copy link
Contributor

RubenKelevra commented Feb 12, 2020

Version information:

go-ipfs version: 0.4.23-6ce9a355f
Repo version: 7
System version: amd64/linux
Golang version: go1.13.7

Description:

I've disabled HAMT sharding for directories on a node that had it previously activated. This results in trouble reading the repo.

Expected behavior

Detect that there's HAMT data and read them anyway, but do not create new HAMT sharded directories

Log

crash_hamt.log

@RubenKelevra RubenKelevra added the kind/bug A bug in existing code (including security flaws) label Feb 12, 2020
@Stebalien Stebalien added the status/duplicate This issue or pull request already exists label Feb 12, 2020
@Stebalien
Copy link
Member

Those crashes are actually from trying to write to a HAMT directory. When sharding is disabled, we won't create new sharded directories but we'll still modify existing ones when requested through MFS.

This is #6860.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) status/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants