Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build fails when zip of repo was used as opposed to git clone #7420

Closed
markg85 opened this issue Jun 5, 2020 · 1 comment · Fixed by #7464
Closed

Docker build fails when zip of repo was used as opposed to git clone #7420

markg85 opened this issue Jun 5, 2020 · 1 comment · Fixed by #7464
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@markg85
Copy link
Contributor

markg85 commented Jun 5, 2020

Hi,

The dockerfile contains:

# Build the thing.
# Also: fix getting HEAD commit hash via git rev-parse.
RUN cd $SRC_DIR \
  && mkdir .git/objects \
  && make build GOTAGS=openssl IPFS_PLUGINS=$IPFS_PLUGINS

The line && mkdir .git/objects \ fails when this repository was obtained using the download zip function in github. As in that case the .git folder won't exist thus mkdir fails as it would need to create 2 directories.

There are 2 potential fixes here.

  1. Just get rid of the line. Nothing seems to be dependent on it.
  2. Change it to: && mkdir -p .git/objects \ (note the -p) to make it work as intended.

I locally changed this to -p which made the build work.

Cheers,
Mark

@markg85 markg85 added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jun 5, 2020
@Stebalien
Copy link
Member

I believe we needed that for some part of the make process (to get the commit0, but I can't remember. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants