Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename url in pin remote to endpoint #7825

Closed
Gozala opened this issue Dec 12, 2020 · 1 comment · Fixed by #7823
Closed

rename url in pin remote to endpoint #7825

Gozala opened this issue Dec 12, 2020 · 1 comment · Fixed by #7823
Assignees
Labels
kind/bug A bug in existing code (including security flaws) status/in-progress In progress

Comments

@Gozala
Copy link

Gozala commented Dec 12, 2020

Per @lidel we use endpoint option everywhere in ipfs-client, but then e.g. if user omits endpoint option go-ipfs will produce error with message "argument "url" is required", which can be very confusing for the user.

We should either change naming in go-ipfs as well from url to endpoint everywhere, or change it back to url in js-ipfs.

@Gozala Gozala added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Dec 12, 2020
@lidel
Copy link
Member

lidel commented Dec 14, 2020

I believe this will be addressed by #7823 where we switched to "endpoint" everywhere

@lidel lidel self-assigned this Dec 14, 2020
@lidel lidel added status/in-progress In progress and removed need/triage Needs initial labeling and prioritization labels Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) status/in-progress In progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants