-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to go-log v2 #8753
Comments
:+1 for making My wishlist is short:
It will enable us to add log explorer with filtering per system in ipfs-webui / ipfs-desktop (cc @SgtPooki) |
@aschmahmann : is this a good candidate for @schomatis ? |
Sounds like it. Will go ahead with this one unless explicitly flagged otherwise. |
Yep seems reasonable. We should probably use the go-log format (https://github.com/ipfs/go-log#golog_log_level) for describing particular subsystems to get logs for though. |
Checklist
Description
https://github.com/ipfs/go-log v2 has been out for quite a while now and go-libp2p v0.18.0 (the biggest source of go-log v1 outputs) is switching over to v2. We should too so that it can finally be deprecated.
This will also lead to the output of
ipfs log tail
becoming effectively useless which is largely happening anyway as a result of other components (e.g. go-libp2p) dropping support for go-log v1. This gives us an opportunity to makeipfs log tail
more useful. For example, mirroring the daemon log output viaipfs log tail
so it can be fetched over the HTTP API and doesn't have to track all log outputs just those from while the command is running.cc @lidel @guseggert
The text was updated successfully, but these errors were encountered: