-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP fetch of fs-migrations should use CAR #9159
Comments
@Jorropo will tackle this after some related light-client work he is doing. |
I've closed #8851 as a duplicate (this one has more context). |
I'm marking this as blocked by the IPIP-402. Once we have that, our life will be easier. Also, I want to add that we need IPNS resolution to solve this too. Copy of my comment:
|
IPIP-402 shipped. Once ipfs.io upgrades to Kubo 0.21 or later, we will be able to fetch We should make it work with all gateways, so if anything is missing in CAR response, fetch it block-by-block (we have prior art in bifrost-gateway). I don't think we should block on IPNS record resolution. |
Version: 0.14.x
Fetching migration data from IPFS was added in #8064, but we did not have #8758 at the time and HTTP fetch is still delegating trust to the gateway.
I consider that a bug: migrations should be fetched in trustless mode as a CAR by requesting them as
?format=car
and verifying every block before applying the migration.This allows us to use third-party gateways af fallback and/or in scenarios where
ipfs.io
is blocked by ISP etc.The text was updated successfully, but these errors were encountered: