Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FUSE IPNS does not update/save new hash (0.4.0) #2168

Open
Kubuxu opened this issue Jan 6, 2016 · 4 comments · May be fixed by #9302
Open

FUSE IPNS does not update/save new hash (0.4.0) #2168

Kubuxu opened this issue Jan 6, 2016 · 4 comments · May be fixed by #9302
Labels
kind/bug A bug in existing code (including security flaws) topic/fuse Topic fuse

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Jan 6, 2016 

[root@test1 ~]# ipfs swarm peers
/ip6/2a03:7380:298:14da:2c00::103/tcp/4001/ipfs/QmPxcxqujyHGMKYPmtbtvLKypkfyvYbjVdnzubPgZDxzGM
[root@test1 ~]# ipfs mount
IPFS mounted at: /ipfs
IPNS mounted at: /ipns
[root@test1 ~]# echo "test" > /ipns/local/test
[root@test1 ~]# ls /ipns/local
test
[root@test1 ~]# pkill ipfs

Received interrupt signal, shutting down...
19:07:09.845 ERROR      mount:  (c *closer) Close(),/ipfs mount.go:91
19:07:09.845 ERROR      mount:  (c *closer) Close(),/ipns mount.go:91
[1]+  Done                    ipfs daemon
[root@test1 ~]# ipfs daemon &
[1] 120
Initializing daemon...
Swarm listening on /ip4/127.0.0.1/tcp/4001
Swarm listening on /ip6/2001:470:c9dd:100:407d:65ff:feb9:f855/tcp/4001
Swarm listening on /ip6/::1/tcp/4001
API server listening on /ip4/127.0.0.1/tcp/5001
Gateway (readonly) server listening on /ip4/127.0.0.1/tcp/8080
Daemon is ready

[root@test1 ~]# ipfs mount
IPFS mounted at: /ipfs
IPNS mounted at: /ipns
[root@test1 ~]# ls /ipns/local
                                                  // Missing file
@em-ly em-ly added kind/bug A bug in existing code (including security flaws) topic/fuse Topic fuse labels Aug 25, 2016
@whyrusleeping
Copy link
Member

@Kubuxu is this still an issue?

@whyrusleeping whyrusleeping added the need/verification This issue needs verification label Mar 6, 2017
@Kubuxu Kubuxu self-assigned this Mar 6, 2017
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 15, 2017 •
edited
Loading

Just tired it again, it is still an issue.

I also got following log during ipfs daemon close:

13:49:20.932 ERROR        mfs: republishRoot error: context canceled system.go:255

@Kubuxu Kubuxu removed the need/verification This issue needs verification label Mar 15, 2017
@Kubuxu Kubuxu removed their assignment Mar 15, 2017
@djdv djdv self-assigned this May 14, 2019
@djdv djdv mentioned this issue May 14, 2019
Closed
@aschmahmann aschmahmann mentioned this issue Oct 31, 2020
Open
@ec1oud
Copy link

ec1oud commented Sep 25, 2022

Still an issue. Is there some reason not to fix it?

@ec1oud
Copy link

ec1oud commented Sep 25, 2022 •
edited
Loading 

func (api *NameAPI) Publish(ctx context.Context, p path.Path, opts ...caopts.NamePublishOption) (coreiface.IpnsEntry, error) {
	ctx, span := tracing.Span(ctx, "CoreAPI.NameAPI", "Publish", trace.WithAttributes(attribute.String("path", p.String())))
	defer span.End()
	fmt.Println("--- name.publish got here?", p, opts)

	if err := api.checkPublishAllowed(); err != nil {
		fmt.Println("--- not allowed!")
		return nil, err
	}

It's (silently) not getting very far in this function for the same reason that the ipfs name publish command doesn't work while ipns is mounted (#1186 #964) So either we need to add a new option like AllowWhileMounted to github.com/ipfs/interface-go-ipfs-core/options, or add another argument to this Publish function to allow an override, or break it up into Publish and DoPublish or something like that.

ec1oud added a commit to ec1oud/kubo that referenced this issue Sep 25, 2022
@ec1oud
Override checkPublishAllowed when the IPNS Fuse mount writes changes
98d342b 
Fixes ipfs#2168
@ec1oud ec1oud linked a pull request Sep 25, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) topic/fuse Topic fuse
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Override checkPublishAllowed when the IPNS Fuse mount writes changes ec1oud/kubo
5 participants
@whyrusleeping @Kubuxu @ec1oud @djdv @em-ly