Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS: support symlinks #9525

Open
3 tasks done
danimesq opened this issue Jan 4, 2023 · 4 comments
Open
3 tasks done

FS: support symlinks #9525

danimesq opened this issue Jan 4, 2023 · 4 comments
Labels
effort/weeks Estimated to take multiple weeks exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@danimesq
Copy link

danimesq commented Jan 4, 2023

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

It returns resolve error when, for example, accessing a index.html that is a symlink.

@danimesq danimesq added the kind/enhancement A net-new feature or improvement to an existing feature label Jan 4, 2023
@Jorropo
Copy link
Contributor

Jorropo commented Jan 4, 2023

@danimesq can you add reproduction steps please ?

@danimesq
Copy link
Author

danimesq commented Jan 4, 2023

@Jorropo for example, look at this site:

https://danimesq.eth.link/tokens/

Now compare with its page:

https://danimesq.eth.link/tokens/dani/

You'll notice the subfolder page is broken compared to its root page.
It's because it uses symlinks.

One of the broken files: https://danimesq.eth.link/tokens/dani/js/owl.carousel.min.js (shows ipfs resolve -r /ipns/danimesq.eth/tokens/dani/js/owl.carousel.min.js: no link named "js" under QmcBJQ9FMJJYBKPqYGqFX8N6vjiVSzqwtcHQVz5y52vt65)

See the live symlink here: https://github.com/danimesq/danimesq.github.io/blob/main/tokens/dani/js

Back in early 2021 I was here reporting issues with accessing a .git folder and seems like it was fixed; now it is the symlink issue that is bugging me

@lidel
Copy link
Member

lidel commented Jan 19, 2023

To unblock this, we need to specify how symlinks are supposed to work in IPFS and Gateway – filled ipfs/specs#368

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Jan 19, 2023
@lidel lidel added P3 Low: Not priority right now effort/weeks Estimated to take multiple weeks exp/expert Having worked on the specific codebase is important labels Feb 13, 2023
@aschmahmann aschmahmann removed the status/blocked Unable to be worked further until needs are met label Mar 6, 2023
@aschmahmann
Copy link
Contributor

removing blocked label because it keeps showing up in our triage board. This issue is linked to the specs one so if someone is interested in pushing on this that's the place to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/weeks Estimated to take multiple weeks exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

4 participants