Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if Swarm.ConnMgr.HighWater is above Swarm.ResourceMgr hard limits #9549

Closed
2 tasks
Tracked by #9442
BigLep opened this issue Jan 14, 2023 · 2 comments · Fixed by #9560
Closed
2 tasks
Tracked by #9442

Fail if Swarm.ConnMgr.HighWater is above Swarm.ResourceMgr hard limits #9549

BigLep opened this issue Jan 14, 2023 · 2 comments · Fixed by #9560
Assignees

Comments

@BigLep
Copy link
Contributor

BigLep commented Jan 14, 2023

Done Criteria

User get a clear message to the console and a terminated process if their Swarm.ConnMgr config has know issues. Specifically:
if the resource manager is enabled,Swarm.ConnMgr.HighWater must be below Swarm.ResourceMgr.System.Conns and (Swarm.ResourceMgr.System.ConnsInbound + Swarm.ResourceMgr.System,ConnsOutbound).

Why Important

If the soft connection manager limits are above the hard resource manager limits, then the soft connection manager will never kick in and there will be a confusing user experience.

This is a footgun that Kubo maintainers have observed during the 0.18RC phase.

Similar to #9546, Swarm.ConnMgr has been present in Kubo for years and users have adjusted this value for their usecses. While #9546 should help, it's still possible that a user's ConnMgr and ResourceMrg limits aren't configured appropriately relative to each other. This acts as a backstop to catch this case.

Notes

@BigLep BigLep moved this to 🥞 Todo in IPFS Shipyard Team Jan 14, 2023
@Jorropo Jorropo moved this from 🥞 Todo to 🏃‍♀️ In Progress in IPFS Shipyard Team Jan 16, 2023
@ajnavarro
Copy link
Member

ajnavarro commented Jan 17, 2023

@Jorropo I assigned it to you because you moved it from TODO to In Progress, to avoid confusion.

@lidel lidel changed the title Fail if Swarm.ConnMgr.HighWater is below Swarm.ResourceMgr hard limits Fail if Swarm.ConnMgr.HighWater is above Swarm.ResourceMgr hard limits Jan 18, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Jan 19, 2023
@BigLep BigLep changed the title Fail if Swarm.ConnMgr.HighWater is above Swarm.ResourceMgr hard limits Fail if Swarm.ConnMgr.HighWater is below Swarm.ResourceMgr hard limits Jan 19, 2023
@BigLep
Copy link
Contributor Author

BigLep commented Jan 19, 2023

@Jorropo @lidel : I saw we have the code change in #9560 . What about the docs change for https://github.com/ipfs/kubo/blob/master/docs/config.md#swarmconnmgr ?

@BigLep BigLep changed the title Fail if Swarm.ConnMgr.HighWater is below Swarm.ResourceMgr hard limits Fail if Swarm.ConnMgr.HighWater is above Swarm.ResourceMgr hard limits Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants