You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
User get a clear message to the console and a terminated process if their Swarm.ConnMgr config has know issues. Specifically:
if the resource manager is enabled,Swarm.ConnMgr.HighWater must be below Swarm.ResourceMgr.System.Conns and (Swarm.ResourceMgr.System.ConnsInbound + Swarm.ResourceMgr.System,ConnsOutbound).
If the soft connection manager limits are above the hard resource manager limits, then the soft connection manager will never kick in and there will be a confusing user experience.
This is a footgun that Kubo maintainers have observed during the 0.18RC phase.
Similar to #9546, Swarm.ConnMgr has been present in Kubo for years and users have adjusted this value for their usecses. While #9546 should help, it's still possible that a user's ConnMgr and ResourceMrg limits aren't configured appropriately relative to each other. This acts as a backstop to catch this case.
lidel
changed the title
Fail if Swarm.ConnMgr.HighWater is below Swarm.ResourceMgr hard limits
Fail if Swarm.ConnMgr.HighWater is above Swarm.ResourceMgr hard limits
Jan 18, 2023
BigLep
changed the title
Fail if Swarm.ConnMgr.HighWater is above Swarm.ResourceMgr hard limits
Fail if Swarm.ConnMgr.HighWater is below Swarm.ResourceMgr hard limits
Jan 19, 2023
BigLep
changed the title
Fail if Swarm.ConnMgr.HighWater is below Swarm.ResourceMgr hard limits
Fail if Swarm.ConnMgr.HighWater is above Swarm.ResourceMgr hard limits
Jan 20, 2023
Done Criteria
User get a clear message to the console and a terminated process if their Swarm.ConnMgr config has know issues. Specifically:
if the resource manager is enabled,
Swarm.ConnMgr.HighWater
must be belowSwarm.ResourceMgr.System.Conns
and (Swarm.ResourceMgr.System.ConnsInbound
+Swarm.ResourceMgr.System,ConnsOutbound
).Why Important
If the soft connection manager limits are above the hard resource manager limits, then the soft connection manager will never kick in and there will be a confusing user experience.
This is a footgun that Kubo maintainers have observed during the 0.18RC phase.
Similar to #9546, Swarm.ConnMgr has been present in Kubo for years and users have adjusted this value for their usecses. While #9546 should help, it's still possible that a user's ConnMgr and ResourceMrg limits aren't configured appropriately relative to each other. This acts as a backstop to catch this case.
Notes
The text was updated successfully, but these errors were encountered: