Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secp256k1 key support is missing pem-pkcs8-cleartext import/export #9912

Open
lidel opened this issue May 31, 2023 · 6 comments
Open

secp256k1 key support is missing pem-pkcs8-cleartext import/export #9912

lidel opened this issue May 31, 2023 · 6 comments
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented May 31, 2023 •
edited
Loading

Seems #9830 was missing a test for --format :)

cc @Jorropo @imthe1

Installation method

built from source

Version

0.20.0-dev

Description

$ ipfs key gen --type=secp256k1 key_secp256k1
$ ipfs key export key_secp256k1 -f pem-pkcs8-cleartext --output key.pem
Error: marshalling key to PKCS8 format: x509: unknown key type while marshaling PKCS#8: *crypto.Secp256k1PrivateKey
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels May 31, 2023
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team May 31, 2023
@Jorropo
Copy link
Contributor

Jorropo commented May 31, 2023

See I was right, I heard about it !

@imthe-1 could you please take a look else I would have to revert for 0.21 ? Sounds easy to fix and add the missing test :'(

I've grepped for Ed25519 and it seems you also missed this too 🙂

kubo/config/init.go

Line 202 in 67e1a17

switch settings.Algorithm {

@imthe-1
Copy link

imthe-1 commented Jun 1, 2023

sure @Jorropo

@Jorropo Jorropo mentioned this issue Jun 2, 2023
Closed
@Jorropo
Copy link
Contributor

Jorropo commented Jun 2, 2023 •
edited
Loading

I think it is fine to release rcs with this bug, but if a PR fixing this is not merged when we do the final 0.21 we will revert 67e1a17. Then PR could be reopenned if anyone want to pick this up.

@Jorropo Jorropo added help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up good first issue Good issue for new contributors and removed need/triage Needs initial labeling and prioritization labels Jun 2, 2023
@imthe-1
Copy link

imthe-1 commented Jun 5, 2023

@Jorropo i am on it now...any rough idea on when we plan to release v0.21?

@Jorropo
Copy link
Contributor

Jorropo commented Jun 5, 2023 •
edited
Loading

@imthe-1 today but I have blocking issues still open so as long as I'm not finished on that it won't happen.
I also have a big 0.21 review queue.

Probably Thursday

@hacdias hacdias mentioned this issue Jun 12, 2023
Merged
@TJKoury
Copy link

TJKoury commented Jan 31, 2024

@imthe-1 Are you still working on this / do you need help with it?

I was using this functionality, updated my install and poof! Need it back and am willing to write code / tests as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
IPFS Shipyard Team
Status: 🥞 Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lidel @TJKoury @Jorropo @imthe-1