Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: update log command help text #2563

Closed
wants to merge 1 commit into from

Conversation

pfista
Copy link
Contributor

@pfista pfista commented Apr 14, 2016

Log levels fatal and panic were removed. Updating command help text to reflect
current log levels available.

Log levels fatal and panic were removed. Updating command help text to reflect
current log levels available.

Fixes ipfs#2551

License: MIT
Signed-off-by: Mike Pfister <pfista@gmail.com>
@whyrusleeping
Copy link
Member

Both of those log levels still exist: https://github.com/ipfs/go-log/blob/master/log.go#L13

@pfista
Copy link
Contributor Author

pfista commented Apr 15, 2016

My mistake, I thought they had been removed based on the comments in #2551 comment

@pfista pfista closed this Apr 15, 2016
@whyrusleeping
Copy link
Member

notes from irc:
'panic' and 'fatal' are both of log level 'critical'. So they arent valid log level names on their own, but we should add critical to this list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants