chore: use common ipfs/*-actions in sync-release-assets #8609
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
galargh
force-pushed
the
go-ipfs-dedup
branch
from
4aa2651 to
f3ee8f4
Compare
| ipfs init --profile flatfs,server | ||
| ipfs daemon --enable-gc=false & | ||
| while (! ipfs id --api "/ip4/127.0.0.1/tcp/5001"); do sleep 1; done | ||
| - name: Wait for go-ipfs to be ready |
There was a problem hiding this comment.
@galargh Can we update ipfs/start-ipfs-daemon-action to include a version of this additional check?
iiuc we want to ensure the ipfs id | jq .Addresses list is not empty before continuing. I believe we had CI randomly fail due to race condition sometimes because libp2p transports did not finish startup
There was a problem hiding this comment.
I want to replace the ipfs build, init and ipfs daemon start logic here with common actions(https://github.com/ipfs/download-ipfs-distribution-action + https://github.com/ipfs/start-ipfs-daemon-action) to minimise duplication. This is part of work related to this issue: #8511
The new logic replaces ipfs build logic with downloading latest stable(non rc) release of go-ipfs from dist.ipfs.io.