Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Golang Core Dev Team - August 13, 2018 #678

Merged
merged 5 commits into from
Aug 22, 2018
Merged

Golang Core Dev Team - August 13, 2018 #678

merged 5 commits into from
Aug 22, 2018

Conversation

keks
Copy link
Contributor

@keks keks commented Aug 13, 2018

The link to the recording is not there yet.

@ghost ghost assigned daviddias Aug 13, 2018
@ghost ghost added the status/in-progress In progress label Aug 13, 2018
@daviddias daviddias changed the title Create 2018-08-13--go-core-dev-team-weekly.md Golang Core Dev Team - August 13, 2018 Aug 13, 2018
@ghost ghost assigned djdv Aug 13, 2018
@djdv
Copy link
Contributor

djdv commented Aug 13, 2018

I refined my notes a bit.

@schomatis
Copy link
Contributor

Sorry for the delay here, I'm pretty sure I can't push to this PR, could someone add my notes please?

@schomatis (not attending)
 - Done:
   - Reviewed a few PRs
   - Studied part of the `gx`/`gx-go` code and workflow, how can we
     make the package manager more user friendly?
 - Next:
   - Start submitting some PRs in `gx`/`gx-go` with documentation

@djdv
Copy link
Contributor

djdv commented Aug 14, 2018

@schomatis
Added.

@daviddias
Copy link
Member

@schomatis gave you access as well for future times!


@marten-seemann (not attending)
- Done:
- various QUIC improvements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marten-seemann, mind enumerating here what improvements were made?

- Fixed a few bugs
- Notable: update gogo protobuf
- Blocked:
- https://github.com/multiformats/multiaddr/pull/68 <- @daviddias P3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: @diasdavid (myself)

- Done:
- Reviewed a bunch of PRs
- Responded to/triaged a bunch of issues
- Fixed a few bugs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any notable bug (that people were eagerly waiting)?

- Next:
- More of the same
- CIDv1
- Finish the protocol negotiation spec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien remind me, is this related with Multistream?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's the "next" version of protocol negotiation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I didn't know that was urgent/P0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sooner we fix it, the better. Every other protocol we have relies on it and we currently (in go at least) try rather hard to reuse streams as creating new ones is expensive (in terms of bandwidth).

For context, inefficient stream negotiation means we need things like libp2p/go-libp2p-kad-dht#92 instead of libp2p/go-libp2p-kad-dht#167.

- Studied part of the `gx`/`gx-go` code and workflow, how can we
make the package manager more user friendly?
- Next:
- Start submitting some PRs in `gx`/`gx-go` with documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean you are fully focused on gx, @schomatis ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment, yes, but I still need to keep an eye on some Badger and go-unixfs issues.

@bigs
- Done:
- Research into virtual network topologies w/ openvswitch/iptools
-> @daviddias introduce travis & jacobheun
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do Github Style!

@travisperson @jacobheun, please meet @bigs. I'm sure you have crossed each other or even met at the IPFS Dev Meetings.

  • @bigs is doing a lot of IPTB work for libp2p testing
  • @travisperson is doing a lot of IPTB work to add support for js-ipfs daemons (Node.js) and js-ipfs browser nodes
  • @jacobheun is looking into designing interop tests that can be used by go-libp2p, js-libp2p and rust-libp2p

It would be great to have you all sync soon to make sure that we leverage everyone's focus and don't get duplicated work done.

- Next:
- Durable implementation of namespaced virtual networking in go-netdef
- Write rendered network config to a file for easy reversal
- Learn virtual NATing?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you end up writing notes, post them on libp2p/notes perhaps?

- Prevents use from building on non-Windows without cgo
- Having mutliple implimentations for the same subcommand seems non-ideal
- Next:
- Schedule to speak with David :^)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 👍 :)

- infra stuff, nothing go related
- blocked
- nothing go related :)
- next
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgierth will you have bandwidth soon to pick ipfs/kubo#4595 back up?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes definitely until end-of-August -- how badly are you blocked?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting ready to do end to end validation, which needs the branch. I started implementing the endpoints in js, but it doesn't currently have refs support. I can look at getting the existing go branch running locally to at least get e2e validation happening. If we can get it live by mid September I think we can still get js peer/content delegated routing out by end of the quarter.

- Blocked:
- https://github.com/multiformats/multiaddr/pull/68 <- @daviddias P3
- https://github.com/multiformats/multiaddr/pull/68#issuecomment-401971665
- Next:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien also, as discussed during the call. Please do the drawing (even if on paper) of something like:
https://github.com/ipfs/js-ipfs#code-architecture-and-folder-structure
image

But for go. Contemplating what is legacy, what is next, including:

  • go-ipfs-cli
  • go-ipfs-cmds
  • go-ipfs-api
  • go-ipfs-core
  • go-ipfs daemon
    • go-ipfs-http-api
    • go-ipfs-http-gateway

And anything else that it is there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus points if you do another for how things are pieced together. Like this one https://github.com/ipfs/js-ipfs#ipfs-core-architecture

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it on paper, I can create the ascii version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dotted means "likely going away". The "Legacy" parts are thin wrappers around some commands to translate between the new system and the old system. The grayed-out parts on the "daemon" diagram are there to show that the code is all the same, it's just that we turn some pieces on and some pieces off depending on whether we're running on the client or the server.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the README with ipfs/kubo#5396

@daviddias daviddias merged commit 0ede519 into ipfs:master Aug 22, 2018
@ghost ghost removed the status/in-progress In progress label Aug 22, 2018
@daviddias daviddias added the 💫 Golang Core Dev go-ipfs, go-libp2p, go-ipld label Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💫 Golang Core Dev go-ipfs, go-libp2p, go-ipld
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants