-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: minimal PWA manifest #310
Conversation
First stab at making it possible to install and run in app mode.
"short_name": "InBrowser IPFS", | ||
"name": "InBrowser IPFS Gateway", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 ideas for better name welcome. We need something short, perhaps just go with inbrowser.link
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think thats about as short as we can go and have it still be semantic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me but i havent looked at a pwa manifest in a long time. Ill need to deploy local and see if i can get it to work
@SgtPooki it is super tricky to test on mobile in LAN due to lack of https, but I was able to do it in desktop Google Chrome with Something that is missing is I am thinking I could add router by converting |
Mac allows you to do simulation of iphone from desktop, i will give this a quick try before i move over to something else |
|
there are some UX issues and issues with content for specs.ipfs.tech. The simulator history back and forward work, but it's hard to trigger.. in general it seems to work okay! |
Thanks! Let's ship this, and add protocol handlers at a later time. |
This PR is the first stab at making it possible to install and run in app mode.
TODO
?uri=
router (details in PWA with handlers for ipfs:// and ipns:// #21)Aims to work towards #21