Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimal PWA manifest #310

Merged
merged 2 commits into from
Jul 4, 2024
Merged

feat: minimal PWA manifest #310

merged 2 commits into from
Jul 4, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Jul 1, 2024

This PR is the first stab at making it possible to install and run in app mode.

TODO

Aims to work towards #21

First stab at making it possible to install and run in app mode.
@lidel lidel added this to the IPFS Camp 2024 milestone Jul 1, 2024
@lidel lidel requested a review from SgtPooki July 1, 2024 19:50
Comment on lines +2 to +3
"short_name": "InBrowser IPFS",
"name": "InBrowser IPFS Gateway",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 ideas for better name welcome. We need something short, perhaps just go with inbrowser.link ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think thats about as short as we can go and have it still be semantic

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me but i havent looked at a pwa manifest in a long time. Ill need to deploy local and see if i can get it to work

@lidel
Copy link
Member Author

lidel commented Jul 1, 2024

@SgtPooki it is super tricky to test on mobile in LAN due to lack of https, but I was able to do it in desktop Google Chrome with goo.localhost:3000, it shows small icon on the right side of address bar that allows installing the PWA.

Something that is missing is protocol_handlers, but we need and ?uri=%s router (specs) for that.

I am thinking I could add router by converting ?uri=%s into /ipxs/id/.. path before passing it to verifiedFetch here, but lmk if there is a better way?
It could also be implemented as redirect response upstream in verified fetch, but not sure how useful it is beyond this project.

@SgtPooki
Copy link
Member

SgtPooki commented Jul 2, 2024

@SgtPooki it is super tricky to test on mobile in LAN due to lack of https, but I was able to do it in desktop Google Chrome with goo.localhost:3000, it shows small icon on the right side of address bar that allows installing the PWA.

Mac allows you to do simulation of iphone from desktop, i will give this a quick try before i move over to something else

@SgtPooki
Copy link
Member

SgtPooki commented Jul 2, 2024

@SgtPooki it is super tricky to test on mobile in LAN due to lack of https, but I was able to do it in desktop Google Chrome with goo.localhost:3000, it shows small icon on the right side of address bar that allows installing the PWA.

Mac allows you to do simulation of iphone from desktop, i will give this a quick try before i move over to something else

image image image image image

@SgtPooki
Copy link
Member

SgtPooki commented Jul 2, 2024

there are some UX issues and issues with content for specs.ipfs.tech. The simulator history back and forward work, but it's hard to trigger.. in general it seems to work okay!

@lidel
Copy link
Member Author

lidel commented Jul 4, 2024

Thanks! Let's ship this, and add protocol handlers at a later time.

@lidel lidel marked this pull request as ready for review July 4, 2024 23:42
@lidel lidel merged commit 6d758c9 into main Jul 4, 2024
19 checks passed
@lidel lidel deleted the pwa branch July 4, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants