feat: config page ux improvements #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
requested changes
Jul 4, 2024
src/lib/config-db.ts
Outdated
| const localStorageGatewaysString = localStorage.getItem(LOCAL_STORAGE_KEYS.config.gateways) ?? JSON.stringify(defaultGateways) | ||
| const localStorageRoutersString = localStorage.getItem(LOCAL_STORAGE_KEYS.config.routers) ?? JSON.stringify(defaultRouters) | ||
| const localStorageDnsResolvers = localStorage.getItem(LOCAL_STORAGE_KEYS.config.dnsJsonResolvers) ?? JSON.stringify(defaultDnsJsonResolvers) | ||
| const localStorageGatewaysString = localStorage.getItem(LOCAL_STORAGE_KEYS.config.gateways) ?? convertUrlArrayToInput(defaultGateways) |
There was a problem hiding this comment.
nit: would it be possible to keep existing behavior (store JSON) and convert to prettier newline delimited representation only in the end users GUI?
Right now, existing users that have preexisting JSON in storage are being broken (screenshot below):
There was a problem hiding this comment.
totally. let me fiddle with that. i created functions for conversion both ways so that shouldn't be a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
feat: config page ux improvements
Description
Updates the config page inputs that were
type=inputto<textarea>and adds descriptions to each input. It makes the page more user-friendly and less prone to input errors.Some style updates were done to resolve a long-standing UX issue with error message placement.
Fixes #290
Notes & open questions
Change checklist