feat: global config validation #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
force-pushed
the
449-create-toggle-component-and-replace-local-storage-toggle-with-it
branch
from
b95d53c to
5e4edf1
Compare
SgtPooki
force-pushed
the
feat/399-global-config-validation
branch
from
3ff8a79 to
55fd164
Compare
3 tasks
Base automatically changed from
449-create-toggle-component-and-replace-local-storage-toggle-with-it
to
main
November 14, 2024 14:14
Also adds more error handling to config-db
SgtPooki
added a commit
that referenced
this pull request
Nov 14, 2024
* fix: dont use local storage for text config items * fix: input toggles dont use localStorage * fix: input-toggle uses resetKey * fix: do not use broadcast channels to tell sw to update config * chore: fix build * feat: global config validation fixes #399 * fix: validate before storing config Also adds more error handling to config-db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #399
Title
feat: global config validation
Description
Adds global config validation on save. This will validate the global config and show an error message if the config is invalid.
Depends on #448 and #450
Fixes #399
Fixes #446
Notes & open questions
Change checklist