Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to manually deregister SW #506

Open
lidel opened this issue Dec 5, 2024 · 1 comment
Open

Document how to manually deregister SW #506

lidel opened this issue Dec 5, 2024 · 1 comment
Labels
need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Dec 5, 2024

The flag is ipfs-sw-deregister in the URL in any way. see

service-worker-gateway/src/lib/deregister-request.ts

Line 4 in fad1eed

const result = urlObj.search.includes('ipfs-sw-deregister')

Unsure whats the best place for this.

  • README?
  • landing page of inbrowser.link itself?
  • message in browser console?
@lidel lidel added need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization labels Dec 5, 2024
@lidel lidel changed the title Document how to reset SW and purge cache Document how to manually deregister SW Dec 5, 2024
@lidel lidel mentioned this issue Dec 5, 2024
Open
@lidel lidel added the P2 Medium: Good to have, but can wait until someone steps up label Dec 6, 2024
@SgtPooki
Copy link
Member

SgtPooki commented Dec 6, 2024

I think having a customization/troubleshooting section in the README as well as a message in the browser console could be useful. we could link to the README section from the About section.

Also, I just tested https://libstc-cc.ipns.inbrowser.dev/ipfs-sw-deregister and ended up in an infinite loop. I will fix that when resolving this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @SgtPooki