Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default port to avoid conflict with gateway #47

Closed
lidel opened this issue Mar 1, 2024 · 3 comments · Fixed by #49
Closed

Change default port to avoid conflict with gateway #47

lidel opened this issue Mar 1, 2024 · 3 comments · Fixed by #49

Comments

@lidel
Copy link
Member

lidel commented Mar 1, 2024

Adding `SOMEGUY_PORT in #45 is a good opportunity to change the default port to avoid conflict with gateway or any other tool that uses 8080 as default.

cc @hacdias @2color I imagine someone may want to try to run kubo (5001, 8080), rainbow (8090 & 8091), and someguy on the same machine. Right now their first experience would be to hit annoying "port taken" error, and having to read docs how to change it even before they can do anything.

Let's change someguy's default port from 8080 to something like 8142 (picked by a totally random dice).

Looks fairly boring and unused, and being in 8XXX range hints at it being HTTP service:

@hacdias
Copy link
Member

hacdias commented Mar 1, 2024

@lidel sounds like a plan to me, but may I suggest 8092? 😆 then we're inline with the others. Or is that too confusing?

@lidel
Copy link
Member Author

lidel commented Mar 1, 2024

8092 works too, unlikely for rainbow to expose another port any time soon. Maybe 8093 just to be safe, and the gap indicates separate service? ;-)

@lidel
Copy link
Member Author

lidel commented Mar 4, 2024

Noticed that SOMEGUY_PORT allows customizing port, while rainbow has RAINBOW_GATEWAY_LISTEN_ADDRESS=127.0.0.1:8090 which allows setting it to 0.0.0.0:8090 to listen on all interfaces.

Perhaps we should unify and make someguy also have SOMEGUY_LISTEN_ADDRESS instead of just port?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants