Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping of quotes and <> in code blocks is broken #19

Closed
lidel opened this issue Jun 19, 2023 · 1 comment · Fixed by #21
Closed

Escaping of quotes and <> in code blocks is broken #19

lidel opened this issue Jun 19, 2023 · 1 comment · Fixed by #21
Assignees
Labels
bug Something isn't working

Comments

@lidel
Copy link
Member

lidel commented Jun 19, 2023

If we have:

```console
[..]
$ curl "http://127.0.0.1:8080/ipfs/$DIR_CID?format=tar" | tar xv
[..]
```

Then it produces:

<div class="remark-highlight"><pre class="language-console"><code class="language-console">
[..]
$ curl &amp;quot;http://127.0.0.1:8080/ipfs/$DIR_CID?format=tar&amp;quot; | tar xv
[..]
</code></pre></div>

because of <pre> it show up mangled in browser, see https://specs.ipfs.tech/ipips/ipip-0288/#user-benefit

2023-06-19_19-14

@lidel lidel changed the title quotes should not be escaped quotes should not be escaped inside of <pre> Jun 19, 2023
@lidel
Copy link
Member Author

lidel commented Nov 7, 2023

Same problem with <> surfaced in ipfs/specs#431:

<Response body as CARv1 stream> <0x00 byte> <Metadata>

produces:

@lidel lidel added the bug Something isn't working label Nov 7, 2023
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team Nov 7, 2023
@lidel lidel changed the title quotes should not be escaped inside of <pre> Escapingof quotes and <> in code blocks is broken Nov 7, 2023
@lidel lidel changed the title Escapingof quotes and <> in code blocks is broken Escaping of quotes and <> in code blocks is broken Nov 7, 2023
@BigLep BigLep mentioned this issue Nov 9, 2023
11 tasks
@github-project-automation github-project-automation bot moved this from 🥞 Todo to 🎉 Done in IPFS Shipyard Team Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants