Skip to content

Commit 1fdd54f

Browse files
lidelbumblefudge
andauthored
Apply suggestions from code review
Co-authored-by: Bumblefudge <bumblefudge@learningproof.xyz>
1 parent 179de96 commit 1fdd54f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: src/http-gateways/subdomain-gateway.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -245,13 +245,13 @@ should return HTTP 400 Bad Request for CIDs longer than 63.
245245

246246
### Wildcard TLS certificates
247247

248-
Wildcard TLS certificates should be set for `*.ipfs.example.net`
248+
Wildcard TLS certificates SHOULD be set for `*.ipfs.example.net`
249249
and `*.ipns.example.net` if a subdomain gateway is to be exposed on the public
250250
internet.
251251

252252
If TLS termination takes place outside of gateway implementation, then setting
253253
[`X-Forwarded-Proto`](#x-forwarded-proto-request-header) at a reverse HTTP
254-
proxy can be used for preserving `https` protocol.
254+
proxy is RECOMMENDED for preserving `https` protocol.
255255

256256
### Public Suffix List and eTLD enforcement
257257

@@ -263,15 +263,15 @@ software like Safe Browsing
263263
([incident example](https://web.archive.org/web/20230930054837/https://blog.nft.storage/posts/2022-04-29-gateways-and-gatekeepers)).
264264

265265
To mitigate this and align with the web’s Same-origin security model, operators
266-
should register a wildcard entry like `*.example.net`
266+
SHOULD register a wildcard entry like `*.example.net`
267267
with the [Public Suffix List (PSL)](https://publicsuffix.org/).
268268

269269
This will make `ipfs.example.net` and `ipns.example.net` eTLDs, treating each
270270
identifier (e.g., `cid.ipfs.example.net`) as a distinct top-level Origin.
271271
The [public good gateway](https://docs.ipfs.tech/concepts/public-utilities/#public-ipfs-gateways),
272272
listed as `*.dweb.link` and `*.inbrowser.link` on the PSL, exemplifies this approach.
273273

274-
Browsers supporting IPFS natively should detect patterns such as
274+
Browsers supporting IPFS natively SHOULD detect URI patterns such as
275275
`https://{content-root-id}.ip[f|n]s.example.net` and dynamically update their
276276
internal PSL, bolstering security and compatibility without relying solely on
277277
operator action.

0 commit comments

Comments
 (0)