Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files browser for 0.4 #221

Closed
wants to merge 2 commits into from
Closed

Files browser for 0.4 #221

wants to merge 2 commits into from

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Jan 24, 2016

WARNING Hacks and bad code in here!

Currently working

  • Create directories
  • Navigate directories
  • Preview images, markdown and raw data

Goals

  •  Clean Code
  •  Video previewer
  •  Code highlighting on text files
  •  Upload files
  •  Move folders and files via drag and drop?
  •  Delete files and folders
  •  Folder creation inline
  •  Better sorting (first folders, then files, set sort order by clicking on the header)
  •  Make it look good
  •  Select on click, double click to open
  •  Inline rename
  •  Copy?

Preview

ipfs-files-2
ipfs-files-first

@jbenet
Copy link
Member

jbenet commented Jan 25, 2016

this looks amazing and i love it.

On Sun, Jan 24, 2016 at 3:31 PM Friedel Ziegelmayer <
notifications@github.com> wrote:

WARNING Hacks and bad code in here!

Currently working

  • Create directories
  • Navigate directories
  • Preview images, markdown and raw data

Goals

  • Clean Code
  • Video previewer
  • Upload files
  • Move folders and files via drag and drop
  • Delete files and folders

Preview

[image: ipfs-files-2]
https://cloud.githubusercontent.com/assets/790842/12539807/a4c31fc4-c2fa-11e5-9a61-c5e9be2d53eb.gif
[image: ipfs-files-first]

https://cloud.githubusercontent.com/assets/790842/12539809/a66e48bc-c2fa-11e5-88dd-27799891eaeb.gif

You can view, comment on, or merge this pull request online at:

#221
Commit Summary

  • Start working on the files browser for 0.4

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#221.

@fazo96
Copy link

fazo96 commented Jan 25, 2016

Wow this looks great!!!

Some other things I think it should have:

  • publish button to publish object (or the root) via IPNS (maybe with an option to folder wrap or not)
  • permalink button (it copies to clipboard or shows an IPFS link to an object)

As a way to copy files:

  • duplicate button (creates a copy in the same folder)
  • move (to move a file or folder) and paste (to paste it somewhere else)

Of course real file manager functionality (select multiple files, move/copy them) would be better but it would get a lot harder to make.

@RichardLitt
Copy link
Member

Agreed that this looks awesome!

@kpcyrd
Copy link

kpcyrd commented Feb 24, 2016

@dignifiedquire could you test a markdown document that contains <script>alert(document.domain)</script> as inline html?

@Kubuxu
Copy link
Member

Kubuxu commented Feb 24, 2016

Are you planning to use highlight.js to highlight source files and maybe detect source files?

@dignifiedquire
Copy link
Member Author

@Kubuxu yes sth like that

@dignifiedquire
Copy link
Member Author

Closing in favor of #229

@jbenet jbenet removed the status/in-progress In progress label Feb 29, 2016
@daviddias daviddias deleted the files branch March 19, 2018 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants