Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ethereum example? #74

Closed
lidel opened this issue Jan 10, 2022 · 6 comments · Fixed by #119
Closed

Remove Ethereum example? #74

lidel opened this issue Jan 10, 2022 · 6 comments · Fixed by #119
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@lidel
Copy link
Collaborator

lidel commented Jan 10, 2022

I believe this example makes more harm than good.
go-ipfs 0.12.0 does not ship with ethereum codec, and when someone tries to open/traverse the DAG it in ANY of our existing IPFS tooling, they get an error:

$ ipfs refs -r bagiacgzah24drzou2jlkixpblbgbg6nxfrasoklzttzoht5hixhxz3rlncyq 
Error: could not choose a decoder: no decoder registered for multicodec code 144 (0x90)

My take: examples should be educational, not confusion-inducing.

Ok to remove it?

cc @mikeal @warpfork @mvdan

@lidel lidel added the need/triage Needs initial labeling and prioritization label Jan 10, 2022
@mvdan
Copy link

mvdan commented Jan 10, 2022

Sounds reasonable to me :) If we lose part of the message that IPLD is interoperable by removing one good example, perhaps we can find another good example that does work on go-ipfs by default.

@SgtPooki SgtPooki added P1 High: Likely tackled by core team if no one steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Feb 2, 2023
@SgtPooki
Copy link
Contributor

SgtPooki commented Feb 2, 2023

Is this something we should remove without a replacement? or is there a suggestion for a replacement we could use?

@lidel
Copy link
Collaborator Author

lidel commented May 25, 2023

Remove it, nobody cared about this enough to fix it for more multiple years, and makes more harm than good.
Child blocks are not provided by anyone, spinner forever, looks broken → makes IPFS/IPLD look bad.

We should not wait for good replacement.

@SgtPooki SgtPooki linked a pull request May 26, 2023 that will close this issue
2 tasks
@SgtPooki
Copy link
Contributor

related: ipfs/js-ipfs#1453

@i-norden
Copy link

i-norden commented Jun 6, 2023

Linking this comment here: https://github.com/ipfs/ipld-explorer-components/pull/360/files/09ab5e813ff38395528ae3ca798e0d7b1e1dea70#r1218762651

All that said I have no strong feelings about removing/not removing the ethereum examples here, just providing some context and potential options.

@SgtPooki
Copy link
Contributor

SgtPooki commented Jun 7, 2023

I was just about to add a link to your comment, thanks for adding that.

I think until we have a good plan forward for ipld-ethereum examples, or a need for users of explore.ipld.io to have ethereum codecs, we should put this on the back burner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants