"invalid key" errors don't print themselves properly

[mvdan]

invalid key for map GulpoStruct: %!q(*basicnode.plainString=0xc000097da0): no such field

The Error method attempts to use %q for an ipld.Node, which will generally not work. It should probably use something like AsString instead, unless we have a better way to print nodes for human reading.

https://github.com/ipld/go-ipld-prime/blob/v0.9.0/errors.go#L95-L101

We should probably look through ipld-prime and fix all uses of %s, %q, %v and so on with ipld.Node, because I think none of those are guaranteed to work.

[warpfork]

We could consider use of printer.Sprint for this now, which was introduced since this issue was first raised.

It might be overkill for this case (?), but might be the right thing to default to if looking at lots of cases of stringing.

[smagdali]

(PL-Launchpad newbie) Oh, this sounds like my kind of thing.

[mvdan]

Go for it! Note that the type now lives under the schema package.

Also note that we shouldn't close this issue until we've looked at the other places where we use format verbs like %q and %s on IPLD nodes. If you're going to just fix the one I found, that's perfectly fine, just don't close the issue yet :)

[smagdali]

assign to me?

also, any clues as to how can I trigger the error for test case?

[mvdan]

You can create an ErrInvalidKey with the Key being a node from https://pkg.go.dev/github.com/ipld/go-ipld-prime/node/basicnode#NewString; I seem to recall that's how I got the bad formatting.