fix: out of scope traversal for 2 or more levels deep

ipld · Oct 26, 2016 · b7a565b · b7a565b
1 parent 2e91d7c
commit b7a565b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
  "name": "ipld-dag-cbor",
  "version": "0.6.0",
  "description": "JavaScript implementation of the IPLD (InterpPlanetary Linked Data)",
- "main": "src/index.js",
+ "main": "lib/index.js",
  "jsnext:main": "src/index.js",
  "scripts": {
  "test": "aegir-test",
@@ -49,6 +49,7 @@
  "aegir": "8.1.2",
  "async": "^2.1.2",
  "chai": "^3.5.0",
+ "ipfs-block": "^0.4.0",
  "pre-commit": "^1.1.3"
  },
  "contributors": [

diff --git a/src/resolver.js b/src/resolver.js
@@ -45,13 +45,11 @@ exports.resolve = (block, path, callback) => {
  }
 
  // out of scope
-
- // TODO this was my first try at writting this out of scope traversal code,
- // it REALLY needs way more testing.
  let value
+ let len = parts.length
 
- for (let i = 0; i < parts.length; i++) {
- let partialPath = parts.shift()
+ for (let i = 0; i < len; i++) {
+ const partialPath = parts.shift()
 
  if (Array.isArray(node) && !Buffer.isBuffer(node)) {
  value = node[Number(partialPath)]