-
Notifications
You must be signed in to change notification settings - Fork 26
fix: replace node buffers with uint8arrays #134
Conversation
BREAKING CHANGE: - `util.serialize` now returns a Uint8Array
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 3 3
Lines 107 107
=======================================
Hits 103 103
Misses 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, with concern about TOC format change, and pending resolution of the CID change.
Do we know that the pass to and from borc is happy with Uint8Arrays too so this is a complete conversion?
README.md
Outdated
- [API](#api) | ||
- [Contribute](#contribute) | ||
- [License](#license) | ||
- [js-ipld-dag-cbor](#js-ipld-dag-cbor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we avoid this as the top-level container of the TOC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your original comment you mention:
util.cid
returns v1CID
s
as breaking change. But isn't that the case already?
Maybe it's badly worded. I meant that the return type of the method has changed - it's now |
Depends on:
BREAKING CHANGE:
util.serialize
now returns a Uint8Arrayutil.cid
returnsCID
s with a breaking API change - see fix: replace node buffers with uint8arrays multiformats/js-cid#117 for changes