Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

fix: replace node buffers with uint8arrays #134

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Aug 3, 2020

Depends on:

BREAKING CHANGE:

BREAKING CHANGE:

- `util.serialize` now returns a Uint8Array
@achingbrain achingbrain requested a review from vmx August 3, 2020 17:04
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files           3        3           
  Lines         107      107           
=======================================
  Hits          103      103           
  Misses          4        4           
Impacted Files Coverage Δ
src/util.js 96.25% <80.00%> (+0.04%) ⬆️
src/resolver.js 95.65% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4646b62...41cb24e. Read the comment docs.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, with concern about TOC format change, and pending resolution of the CID change.

Do we know that the pass to and from borc is happy with Uint8Arrays too so this is a complete conversion?

README.md Outdated
- [API](#api)
- [Contribute](#contribute)
- [License](#license)
- [js-ipld-dag-cbor](#js-ipld-dag-cbor)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we avoid this as the top-level container of the TOC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your original comment you mention:

  • util.cid returns v1 CIDs

as breaking change. But isn't that the case already?

@achingbrain
Copy link
Member Author

achingbrain commented Aug 4, 2020

Maybe it's badly worded. I meant that the return type of the method has changed - it's now js-cid@v1.0.0, with the renamed .bytes property, not v0/v1 CID/multihashes.

@vmx vmx merged commit 41587e7 into master Aug 4, 2020
@vmx vmx deleted the fix/replace-node-buffers-with-uint8arrays branch August 4, 2020 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants