Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

feat: CBOR TAG #38

Merged
merged 3 commits into from
Jan 31, 2017
Merged

feat: CBOR TAG #38

merged 3 commits into from
Jan 31, 2017

Conversation

daviddias
Copy link
Member

fixes #33

Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that there is amore efficient way, using the custom tag feature of borc. i can provide you with a PR if you want

@daviddias
Copy link
Member Author

@dignifiedquire bring it on :) I didn't know of a 'custom undocumented feature' of borc :P

@daviddias daviddias merged commit 13323a2 into master Jan 31, 2017
@daviddias daviddias deleted the feat/use-tag branch January 31, 2017 12:58
@daviddias daviddias removed the status/in-progress In progress label Jan 31, 2017
@peteroupc
Copy link

peteroupc commented Aug 1, 2019

Note that tag 42, as specified here, is currently registered with IANA with an unrelated meaning: as a YANG schema item identifier. This stresses that new CBOR tags should be registered with IANA before using them in code.

@mikeal
Copy link
Contributor

mikeal commented Aug 1, 2019

core-wg/yang-cbor#13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing cbor tag encoding
4 participants